Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added NATS - a new implementor for the messaging capability! #354

Merged
merged 15 commits into from
Mar 13, 2023
Merged

added NATS - a new implementor for the messaging capability! #354

merged 15 commits into from
Mar 13, 2023

Conversation

danbugs
Copy link
Collaborator

@danbugs danbugs commented Mar 10, 2023

closes #353

@danbugs danbugs added the ✨ feature New feature or feature request label Mar 10, 2023
@danbugs danbugs added this to the [KUBECON] March Milestone milestone Mar 10, 2023
devigned
devigned requested changes Mar 10, 2023
View reviewed changes
Copy link
Member

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impl looks good. Just a little feedback on drying up some of the error messaging.

src/commands/run.rs Show resolved Hide resolved
Mossaka
Mossaka reviewed Mar 10, 2023
View reviewed changes
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm!

build/azure-pipeline/workflow-pr.yml Outdated Show resolved Hide resolved
examples/configs-demo/Cargo.lock Show resolved Hide resolved
crates/messaging/src/implementors/natsio.rs Show resolved Hide resolved
@danbugs danbugs merged commit 2fe3936 into deislabs:main Mar 13, 2023
@danbugs danbugs deleted the danbugs/nats branch March 16, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devigned devigned devigned requested changes

@Mossaka Mossaka Mossaka approved these changes

Assignees
No one assigned
Labels
✨ feature New feature or feature request
Projects
None yet
Milestone
Milestone
Development

Successfully merging this pull request may close these issues.

make NATS implementation
3 participants
@danbugs @devigned @Mossaka