Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added cli option to link all caps needed for dynamic langs #386

Merged
merged 2 commits into from
Apr 26, 2023
Merged

added cli option to link all caps needed for dynamic langs #386

merged 2 commits into from
Apr 26, 2023

Conversation

danbugs
Copy link
Collaborator

@danbugs danbugs commented Apr 16, 2023

No description provided.

@danbugs danbugs added the ✨ feature New feature or feature request label Apr 16, 2023
@danbugs danbugs requested a review from Mossaka April 16, 2023 18:13
@danbugs
fix && fmt
1d61d1d 
Signed-off-by: danbugs <[email protected]>
Mossaka
Mossaka approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! What is the short form of "link_all_capabilities" in slight CLI?

@danbugs
Copy link
Collaborator Author

danbugs commented Apr 24, 2023

It's -l.

@Mossaka Mossaka closed this Apr 26, 2023
@Mossaka Mossaka reopened this Apr 26, 2023
@Mossaka
Copy link
Member

Mossaka commented Apr 26, 2023

It's -l.

I wonder if -a or -all makes more sense to enable all capabilities in slight.

@Mossaka Mossaka merged commit f43f917 into deislabs:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mossaka Mossaka Mossaka approved these changes

Assignees
No one assigned
Labels
✨ feature New feature or feature request
Projects
Wasm Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danbugs @Mossaka