Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http client requests can now have a body #390

Merged
merged 2 commits into from
Apr 27, 2023
Merged

http client requests can now have a body #390

merged 2 commits into from
Apr 27, 2023

Conversation

danbugs
Copy link
Collaborator

@danbugs danbugs commented Apr 24, 2023

No description provided.

@danbugs danbugs added the ✨ feature New feature or feature request label Apr 24, 2023
@danbugs danbugs requested a review from Mossaka April 24, 2023 17:51
devigned
devigned requested changes Apr 24, 2023
View reviewed changes
Copy link
Member

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... body is definitely something we would want to send.

Do you think you could add a test to ensure this does not regress?

@Mossaka Mossaka closed this Apr 26, 2023
@Mossaka Mossaka reopened this Apr 26, 2023
Mossaka
Mossaka approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Mossaka Mossaka enabled auto-merge (squash) April 27, 2023 21:02
@Mossaka Mossaka disabled auto-merge April 27, 2023 21:02
@Mossaka Mossaka merged commit 47314ea into deislabs:main Apr 27, 2023
@danbugs danbugs deleted the danbugs/add-body-to-http-req branch April 27, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devigned devigned devigned requested changes

@Mossaka Mossaka Mossaka approved these changes

Assignees
No one assigned
Labels
✨ feature New feature or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danbugs @devigned @Mossaka