Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure always pickup the same port #1210

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

Sgitario
Copy link
Collaborator

@Sgitario Sgitario commented Jun 12, 2023

If the container ports are generated in a different order, the port is pickup in a different order.

With this change, the logic to pick up the http to use is consistent.

I saw this issue when generating a Quarkus application. It randomly picks up the HTTP or the HTTPS in the generated Health probes.

If the container ports are generated in a different order, the port is pickup in a different order. 

With this change, the logic to pick up the http to use is consistent.
@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants