Add test for: to_scalar_value #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marijn Valk <[email protected]>
marijncv
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
Signed-off-by: Marijn Valk <[email protected]>
|
Thanks @marijncv - contributing tests is both very valuable for the project as well as a good way to learn a project and language :). |
roeap
approved these changes
Jan 23, 2023
chitralverma
pushed a commit
to chitralverma/delta-rs
that referenced
this pull request
Mar 17, 2023
Signed-off-by: Marijn Valk <[email protected]> # Description Adds a simple unit test for `to_scalar_value` P.S. Rust beginner here, trying to get to know the language a bit better Signed-off-by: Marijn Valk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marijn Valk [email protected]
Description
Adds a simple unit test for
to_scalar_valueP.S. Rust beginner here, trying to get to know the language a bit better