feat: add nested struct supports #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haruband
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
roeap,
rtyler and
mosyp
as code owners
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
rtyler
reviewed
Jul 13, 2023
rust/src/operations/write.rs
Outdated
Comment on lines
496
to
498
| fn can_cast_batch(from_schema: &ArrowSchema, to_schema: &ArrowSchema) -> bool { | ||
| can_cast_batch_fields(from_schema.fields(), to_schema.fields()) | ||
| } |
There was a problem hiding this comment.
Suggested change
| fn can_cast_batch(from_schema: &ArrowSchema, to_schema: &ArrowSchema) -> bool { | |
| can_cast_batch_fields(from_schema.fields(), to_schema.fields()) | |
| } |
Since there is only one callsite of this method and it is not a public API, I figure it makes sense to just remove it
There was a problem hiding this comment.
I agree with you. I pushed new commit.
Thanks for the review.
This commit allows to check and cast record batches with column of type nested struct.
This test checks if a field in nested struct is casted.
rtyler
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds nested struct supports.
Related Issue(s)
Documentation