feat!: bulk delete for vacuum #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
binding/python
Blajda
requested review from
wjones127,
fvaleye,
rtyler,
roeap,
houqp,
xianwill and
mosyp
as code owners
wjones127
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bulk delete was added to the object store apache/arrow-rs#2615 which deletes multiple files within a single API call if the underlying store supports it. If it is not supported then concurrent requests are performed underneath.
This PR updates vacuum with the object store changes. Currently on S3 will see any benefits since the default bulk delete is not overridden for other backends.
Related Issue(s)