feat: drop python 3.7 and adopt 3.12 #1859
Conversation
|
@rtyler - i believe you may have to take that one, as it requires updating the required tests ... In the end we were running the 3.7 tests in a manylinux container that we used to use also for builds. we have since then changed to the github action, so i felt using the approach we use in the other tests would be OK. Just hoping that we don't run into the same issues again in the next release, as the action may as well use a similar manylinux image. But hopefully one, where all build dependencies etc for openssl are compatible with the versions we need in the build... |
ion-elgreco
force-pushed
the
drop-py37
branch
from
549bdac
to
8c2903e
Compare
| # actions/checkout@v3 is a node action, which runs on a fairly new | ||
| # version of node. however, manylinux environment's glibc is too old for | ||
| # that version of the node. so we will have to use v1 instead, which is a | ||
| # docker based action. | ||
| - uses: actions/checkout@v1 |
There was a problem hiding this comment.
Can leave this as a TODO, but I think the proper thing to do would be use the Maturin action to build in manylinux like we do for the release jobs.
Description
This change is mainly motivated by the current build failures on main. Since 3.7 is EOL and we have been meaning to drop it for a while, I thought maybe its good to give that a try before diving deeper into the inners of openssl build failures.
Closes #1703