Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: express log schema in delta types #1876

Merged
merged 1 commit into from
Nov 18, 2023
Merged

refactor: express log schema in delta types #1876

merged 1 commit into from
Nov 18, 2023

Conversation

roeap
Copy link
Collaborator

@roeap roeap commented Nov 18, 2023

Description

This PR updates the core schema definitions for log and checkpoint actions:

  • write in terms of delta types rather then arrow types
  • fix some inconsistencies in action types
  • extend to handle actions required to v2 checkpoints

Related Issue(s)

part of: #1776 #1568

@github-actions github-actions bot added binding/rust Issues for the Rust crate crate/core labels Nov 18, 2023
@roeap roeap mentioned this pull request Nov 18, 2023
Merged
rtyler
rtyler approved these changes Nov 18, 2023
View reviewed changes
crates/deltalake-core/src/kernel/actions/types.rs
@@ -264,7 +257,7 @@ pub enum WriterFeatures {
/// ID Columns
IdentityColumns,
/// Deletion vectors for merge, update, delete
DeleteionVecotrs,
DeletionVectors,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@rtyler rtyler merged commit dd6b453 into delta-io:main Nov 18, 2023
21 checks passed
@roeap roeap deleted the arrow-state branch November 19, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtyler rtyler rtyler approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

Assignees
No one assigned
Labels
binding/rust Issues for the Rust crate crate/core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roeap @rtyler