feat: extend write_deltalake to accept Deltalake schema #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r3stl355
requested review from
wjones127,
fvaleye,
roeap and
ion-elgreco
as code owners
ion-elgreco
force-pushed
the
issue-1862-attempt-2
branch
from
900626b
to
7ba6aa7
Compare
ion-elgreco
approved these changes
Nov 29, 2023
ion-elgreco
requested changes
Nov 29, 2023
Signed-off-by: Nikolay Ulmasov <[email protected]>
ion-elgreco
approved these changes
Nov 29, 2023
ion-elgreco
pushed a commit
to ion-elgreco/delta-rs
that referenced
this pull request
Dec 1, 2023
# Description A second attempt to extend the write_deltalake to accept either PyArrow or Deltalake schema (messed up the previous PR with some rebase issues) Added a test # Related Issue(s) closes delta-io#1862 --------- Signed-off-by: Nikolay Ulmasov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A second attempt to extend the write_deltalake to accept either PyArrow or Deltalake schema (messed up the previous PR with some rebase issues)
Added a test
Related Issue(s)
closes #1862