Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): add more commit info to most operations #2009

Merged
merged 12 commits into from
Jan 4, 2024

Conversation

ion-elgreco
Copy link
Collaborator

Description

Some operations were not writing the readVersion and operationMetrics to the commitInfo. This adds that to those operations as well.

@github-actions github-actions bot added binding/rust Issues for the Rust crate crate/core labels Jan 1, 2024
@ion-elgreco
Copy link
Collaborator Author

@roeap I can also undo the change of the commit in restore, then we can look at that another time?

@ion-elgreco
Copy link
Collaborator Author

@rtyler @roeap I've removed the high level commit and reverted back to the old version for restore : )

Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far.

I do think we can avoid cloning these metrics, and with that also don't need the Clone implementations.

crates/deltalake-core/src/operations/delete.rs Outdated Show resolved Hide resolved
@roeap roeap merged commit 236fa74 into delta-io:main Jan 4, 2024
20 checks passed
r3stl355 pushed a commit to r3stl355/delta-rs that referenced this pull request Jan 10, 2024
# Description
Some operations were not writing the readVersion and operationMetrics to
the commitInfo. This adds that to those operations as well.

---------

Co-authored-by: Robert Pack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate crate/core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants