feat: allow merge_execute to release the GIL #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcake
requested review from
wjones127,
fvaleye,
roeap and
ion-elgreco
as code owners
wjones127
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows calls to
merge_executeto release the GIL to allow other python threads to carry on in parallel.I believe this is safe because every argument is a rust-marshaled type apart from
sourcewhich is pyarrow-marshaled and C under the hood. All pyarrow types are immutable I believe, so by this point it should be safe to read with the GIL unlocked.Related Issue(s)
it looks like there is a change in the works (PyO3/pyo3#3610) to allow this to be an attribute but it's not ready yet. For now it looks a little ugly putting it in the closure.