fix: fixes panic on empty write #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aersam
requested review from
wjones127,
fvaleye,
roeap,
ion-elgreco and
rtyler
as code owners
github-actions
bot
added
binding/python
rtyler
approved these changes
Mar 6, 2024
|
@aersam can you make it possible that we can update branches in your repo? Then we can just rebase ourselves :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just adds a test to check_preconditions to avoid failure when writing an empty RecordBatchReader
In addition I had to fix chrono to 0.4.34, since 0.4.35 seems to be breaking the tests, delta-rs uses some deprecated methods
Related Issue(s)