chore: expose files_by_partition to public api
#2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmondop
requested review from
wjones127,
fvaleye,
roeap and
ion-elgreco
as code owners
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
edmondop
changed the title
edmondop
changed the title
edmondop
changed the title
edmondop
changed the title
ion-elgreco
force-pushed
the
missing-python-method
branch
from
4b517db
to
f248403
Compare
ion-elgreco
changed the title
files_by_partition to public api
|
@edmondop can you fix the linting issues? Then we can merge it |
ion-elgreco
previously approved these changes
Jun 4, 2024
|
I fixed the linting, but I think I should add a test since I have grown the API surface before this get merged. I submitted to verify if I was wrong in reading the documentation or if a method was missing from the public api |
|
@ion-elgreco looks also there is a flaky concurrency test |
ion-elgreco
approved these changes
Jun 4, 2024
|
@edmondop let me know when you added the test |
ion-elgreco
force-pushed
the
missing-python-method
branch
from
600e2e3
to
31c2348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This documentation describes the usage of
files_by_partitionbut that API doesn't seem to be surfaced from the underlying rust implementation