test: reintroduce azurite SAS integration tests #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomorebecchi
requested review from
wjones127,
fvaleye,
roeap and
ion-elgreco
as code owners
|
Thankss! <3 |
ion-elgreco
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reintroduce integration tests using Azurite and SAS tokens.
These tests were skipped believing that the mistake was due to the upgrade of version in
object-store>=0.9.1". Actually, whatobject-store` started doing from that version on, is really using the SAS token for the first time. For more details, see:I changed the command to create the SAS token using the
azure-storage-bloblibrary (adding it to the dev deps), rather than the azure CLI, and removed the pytest markers to skip the tests.@ion-elgreco pinging you as promised, sorry if this took more time than expected!