feat(#2597): allow pyarrow.dataset.Expression in filters kwarg #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomorebecchi
requested review from
wjones127,
fvaleye,
roeap and
ion-elgreco
as code owners
giacomorebecchi
force-pushed
the
2597-allow-expression-in-filters
branch
from
16066bd
to
6c9151b
Compare
|
@ion-elgreco fixed both errors that were spotted in the actions run, sorry for overlooking them! |
ion-elgreco
force-pushed
the
2597-allow-expression-in-filters
branch
from
6c9151b
to
a3bf95e
Compare
|
looks like we need to add a few type hints to the pyarrow pyi files (in this repo) for linting to pass. |
giacomorebecchi
force-pushed
the
2597-allow-expression-in-filters
branch
from
a3bf95e
to
5184ccb
Compare
Please let me know if my last commit works, thanks for your patience! |
ion-elgreco
force-pushed
the
2597-allow-expression-in-filters
branch
from
5184ccb
to
1561d63
Compare
giacomorebecchi
force-pushed
the
2597-allow-expression-in-filters
branch
from
1561d63
to
88fd969
Compare
ion-elgreco
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow
pyarrow.dataset.Expressioninfilterskwarg ofdeltalake.DeltaTable.to_pyarrow_tableanddeltalake.DeltaTable.to_pandasmethods, and remove code dupllication in favor of the pyarrow implementation.Related Issue(s)
pyarrow.dataset.Expressioninfilterskwarg ofdeltalake.DeltaTable.to_pyarrow_table#2597