feat: introduce CDC generation for merge operations #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the beginning of the work but represents working `delete` `_change_type` information being produced on the merge operation
This does not have as much testing as it probably should, but preliminary results are looking good!
rtyler
requested review from
wjones127,
roeap,
hntd187 and
ion-elgreco
as code owners
ion-elgreco
reviewed
Aug 10, 2024
| .and(col(TARGET_COLUMN).is_null()), | ||
| )? | ||
| .select(write_projection.clone())? | ||
| .with_column(CDC_COLUMN_NAME, lit("insert"))?, |
There was a problem hiding this comment.
Why do we create inserts? Isn't it cheaper to let the cdf_reader calculate what was inserted?
Hmm so while checking this action, it seems our cdf_reader doesn't properly do this
There was a problem hiding this comment.
@rtyler I think we can add one optimization here, if we see it's insert only. So there is only a when_not_matched_insert_all statement, then we could avoid writing CDC as a whole.
ion-elgreco
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's been a slog y'all