feat: improved test fixtures #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeap
requested review from
wjones127,
rtyler,
hntd187 and
ion-elgreco
as code owners
ion-elgreco
reviewed
Aug 11, 2024
roeap
force-pushed
the
feature/improved-pruning
branch
from
1b2e035
to
d35c6d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is mainly preparation for the work we need to do on data skipping.
It intorduces a new set of test utilities, but at least also gets rid of one other "test_utils" file. Over the next few PRs I hope to gradually consolidate our usage on "Localized" test utitlitis and use the shared ones.
Initially I wanted to place this in the
testcrate, but somehow cargo kept on complaining about version conflicts, regarding the action structs.We also add a function to get the partition values schema on snapshot, which I forgot to remove in rebasing some commits. WE will need it going forward so I was hoping it does not add too much complexity to this PR.