Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure log store correctly identifies existing delta tables #2890

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Sep 20, 2024

If a process fails before the initial commit is able it's possible for _commit(.*).tmp to be placed inside _delta_log/ and then a subsequent attempt to the create the delta table will fail because the log store believes it has been created but no initial transaction exists.

Sponsored-by: Scribd Inc.

If a process fails before the initial commit is able it's possible for
_commit(.*).tmp to be placed inside _delta_log/ and then a subsequent
attempt to the create the delta table will fail because the log store
believes it has been created but no initial transaction exists.

Sponsored-by: Scribd Inc.
@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (55a19f6) to head (8d85f3a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/logstore/mod.rs 86.66% 1 Missing and 3 partials ⚠️
crates/core/src/storage/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2890      +/-   ##
==========================================
+ Coverage   72.39%   72.41%   +0.01%     
==========================================
  Files         133      133              
  Lines       40253    40281      +28     
  Branches    40253    40281      +28     
==========================================
+ Hits        29142    29169      +27     
  Misses       9240     9240              
- Partials     1871     1872       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtyler rtyler marked this pull request as ready for review September 20, 2024 22:04
@rtyler rtyler added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
@rtyler rtyler added this pull request to the merge queue Sep 20, 2024
Merged via the queue into delta-io:main with commit c123129 Sep 20, 2024
24 checks passed
@rtyler rtyler deleted the bug/s3-table-create branch September 20, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants