Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: exposing CommitConflictError enum #2907

Merged

Conversation

Filip-Dziuba
Copy link
Contributor

@Filip-Dziuba Filip-Dziuba commented Sep 25, 2024

TransactionError::CommitConflict exposes private CommitConflictError.
Cleaner access to Commit Conflict, allowing handling it in match for metrics/logging/error handling.

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Sep 25, 2024
@alexwilcoxson-rel
Copy link
Contributor

Thanks @Filip-Dziuba !

@ion-elgreco @rtyler as Filip mentions we don't have a way to match on why commits conflict. With this we can improve our conflict handling.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.51%. Comparing base (5d10cbe) to head (973ee8e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2907      +/-   ##
==========================================
+ Coverage   72.48%   72.51%   +0.02%     
==========================================
  Files         131      131              
  Lines       40421    40421              
  Branches    40421    40421              
==========================================
+ Hits        29300    29311      +11     
  Misses       9238     9238              
+ Partials     1883     1872      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco ion-elgreco added this pull request to the merge queue Sep 25, 2024
Merged via the queue into delta-io:main with commit 2498837 Sep 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants