-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(runtime/js/workers): throw errors instead of using an op (#12249)
- Loading branch information
Showing
23 changed files
with
74 additions
and
74 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
// deno-lint-ignore require-await | ||
(async () => { | ||
throw new Error("bar"); | ||
})(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
postMessage("ready"); | ||
onmessage = () => { | ||
throw new Error("bar"); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[WILDCARD]error: Uncaught (in worker "") Cannot resolve module "file:///[WILDCARD]/workers/doesnt_exist.js". | ||
error: Uncaught (in promise) Error: Unhandled error event reached main worker. | ||
error: Uncaught (in promise) Error: Unhandled error event in child worker. | ||
at Worker.#pollControl ([WILDCARD]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
error: Uncaught (in worker "") Requires read access to "[WILDCARD]local_file.ts", run again with the --allow-read flag | ||
at blob:null/[WILDCARD]:1:0 | ||
error: Uncaught (in promise) Error: Unhandled error event reached main worker. | ||
error: Uncaught (in promise) Error: Unhandled error event in child worker. | ||
at Worker.#pollControl ([WILDCARD]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
error: Uncaught (in worker "") Requires net access to "example.com", run again with the --allow-net flag | ||
at blob:null/[WILDCARD]:1:0 | ||
error: Uncaught (in promise) Error: Unhandled error event reached main worker. | ||
error: Uncaught (in promise) Error: Unhandled error event in child worker. | ||
at Worker.#pollControl ([WILDCARD]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
error: Uncaught (in worker "") Requires read access to "[WILDCARD]local_file.ts", run again with the --allow-read flag | ||
at data:application/javascript;base64,[WILDCARD]:1:0 | ||
error: Uncaught (in promise) Error: Unhandled error event reached main worker. | ||
error: Uncaught (in promise) Error: Unhandled error event in child worker. | ||
at Worker.#pollControl ([WILDCARD]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
error: Uncaught (in worker "") Requires net access to "example.com", run again with the --allow-net flag | ||
at data:application/javascript;base64,aW1wb3J0ICJodHRwczovL2V4YW1wbGUuY29tL3NvbWUvZmlsZS50cyI7:1:0 | ||
error: Uncaught (in promise) Error: Unhandled error event reached main worker. | ||
error: Uncaught (in promise) Error: Unhandled error event in child worker. | ||
at Worker.#pollControl ([WILDCARD]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
error: Uncaught (in worker "") Requires net access to "example.com", run again with the --allow-net flag | ||
at http://localhost:4545/workers/static_remote.ts:2:0 | ||
error: Uncaught (in promise) Error: Unhandled error event reached main worker. | ||
error: Uncaught (in promise) Error: Unhandled error event in child worker. | ||
at Worker.#pollControl ([WILDCARD]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,8 @@ | ||
let thrown = false; | ||
|
||
if (self.name !== "") { | ||
throw Error(`Bad worker name: ${self.name}, expected empty string.`); | ||
} | ||
|
||
onmessage = function (e) { | ||
if (thrown === false) { | ||
thrown = true; | ||
throw new SyntaxError("[test error]"); | ||
} | ||
|
||
postMessage(e.data); | ||
close(); | ||
}; | ||
|
||
onerror = function () { | ||
return false; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
const worker = new Worker( | ||
new URL("async_error.ts", import.meta.url).href, | ||
{ type: "module", name: "foo" }, | ||
); | ||
setTimeout(() => worker.terminate(), 30000); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
error: Uncaught (in worker "foo") (in promise) Error: bar | ||
throw new Error("bar"); | ||
^ | ||
at [WILDCARD]/async_error.ts:[WILDCARD] | ||
at [WILDCARD]/async_error.ts:[WILDCARD] | ||
error: Uncaught (in promise) Error: Unhandled error event in child worker. | ||
at Worker.#pollControl ([WILDCARD]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
[WILDCARD]error: Uncaught (in worker "bar") Error: foo[WILDCARD] | ||
at foo ([WILDCARD]) | ||
at [WILDCARD] | ||
error: Uncaught (in promise) Error: Unhandled error event reached main worker. | ||
error: Uncaught (in promise) Error: Unhandled error event in child worker. | ||
at Worker.#pollControl ([WILDCARD]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
const worker = new Worker( | ||
new URL("message_handler_error.ts", import.meta.url).href, | ||
{ type: "module", name: "foo" }, | ||
); | ||
worker.onmessage = () => { | ||
worker.postMessage("ready"); | ||
}; | ||
setTimeout(() => worker.terminate(), 30000); |
7 changes: 7 additions & 0 deletions
7
cli/tests/testdata/workers/worker_message_handler_error.ts.out
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
error: Uncaught (in worker "foo") (in promise) Error: bar | ||
throw new Error("bar"); | ||
^ | ||
at onmessage ([WILDCARD]/message_handler_error.ts:[WILDCARD]) | ||
at [WILDCARD] | ||
error: Uncaught (in promise) Error: Unhandled error event in child worker. | ||
at Worker.#pollControl ([WILDCARD]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
[WILDCARD]error: Uncaught (in worker "bar") Error: foo[WILDCARD] | ||
at foo ([WILDCARD]) | ||
at [WILDCARD] | ||
error: Uncaught (in promise) Error: Unhandled error event reached main worker. | ||
throw new Error("foo"); | ||
^ | ||
at foo ([WILDCARD]/workers/error.ts:[WILDCARD]) | ||
at [WILDCARD]/workers/error.ts:[WILDCARD] | ||
error: Uncaught (in worker "baz") (in promise) Error: Unhandled error event in child worker. | ||
at Worker.#pollControl ([WILDCARD]) | ||
error: Uncaught (in promise) Error: Unhandled error event in child worker. | ||
at Worker.#pollControl ([WILDCARD]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters