Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): lint watch mode #11983

Merged
merged 15 commits into from
Oct 5, 2021
Merged

feat(cli): lint watch mode #11983

merged 15 commits into from
Oct 5, 2021

Conversation

CGQAQ
Copy link
Contributor

@CGQAQ CGQAQ commented Sep 11, 2021

Signed-off-by: CGQAQ [email protected]

fix #11132

magurotuna
magurotuna reviewed Sep 11, 2021
View reviewed changes
Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add integration tests to make sure it works fine? You can refer to the existing examples of watcher tests in https:/denoland/deno/blob/d236f432b86de55c6006778b0c68fe60b6419069/cli/tests/integration/watcher_tests.rs

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Sep 11, 2021

Can you add integration tests to make sure it works fine? You can refer to the existing examples of watcher tests in https:/denoland/deno/blob/d236f432b86de55c6006778b0c68fe60b6419069/cli/tests/integration/watcher_tests.rs

sure, I'll definitely do that

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Sep 11, 2021

@magurotuna Added tests, please re-review it :)

@CGQAQ CGQAQ changed the title feat. lint watch mode feat(cli): lint watch mode Sep 12, 2021
bartlomieju
bartlomieju reviewed Sep 12, 2021
View reviewed changes
cli/tools/lint.rs Outdated Show resolved Hide resolved
bartlomieju
bartlomieju reviewed Sep 12, 2021
View reviewed changes
cli/tools/lint.rs Outdated Show resolved Hide resolved
cli/tools/lint.rs Outdated Show resolved Hide resolved
cli/tests/testdata/badly_linted.mjs Outdated Show resolved Hide resolved
cli/tests/integration/watcher_tests.rs Outdated Show resolved Hide resolved
@CGQAQ
Copy link
Contributor Author

CGQAQ commented Sep 12, 2021

Will change these tonight, it’s Monday morning here, gotta go to work

@bartlomieju bartlomieju added this to the 1.15.0 milestone Sep 13, 2021
@CGQAQ
Copy link
Contributor Author

CGQAQ commented Sep 21, 2021

When will this gets to merge

@caspervonb
Copy link
Contributor

When will this gets to merge

It is tagged for 1.5, merge window for that opens in about two weeks 🙂

bartlomieju
bartlomieju reviewed Sep 24, 2021
View reviewed changes
cli/tests/testdata/lint/expected_glob.out Outdated Show resolved Hide resolved
cli/tools/lint.rs Outdated Show resolved Hide resolved
cli/tools/lint.rs Outdated Show resolved Hide resolved
@bartlomieju bartlomieju mentioned this pull request Oct 4, 2021
Merged
bartlomieju
bartlomieju approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @CGQAQ

@bartlomieju bartlomieju merged commit c555b31 into denoland:main Oct 5, 2021
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Oct 10, 2021
@CGQAQ @bartlomieju
feat(lint): add support for --watch flag (denoland#11983)
3bfab8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magurotuna magurotuna magurotuna left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

deno lint --watch
4 participants
@CGQAQ @caspervonb @bartlomieju @magurotuna