feat(ext/crypto): implement deriveKey #12117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase |
bnoordhuis
approved these changes
Oct 9, 2021
ext/crypto/00_crypto.js
Outdated
| ); | ||
| } | ||
| } else if (algorithm.length !== 0) { | ||
| length == algorithm.length; |
There was a problem hiding this comment.
Suggested change
| length == algorithm.length; | |
| length = algorithm.length; |
I'd just return here (and above too - easier to reason about.)
There was a problem hiding this comment.
It's just following the steps as per spec. Easier for anyone reading/debugging with the spec open alongside IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #11690
Large WPT diff because of missing importKey and some previously false tests were disabled.