Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/fetch): avoid panic when header is invalid #12244

Merged
merged 3 commits into from
Sep 29, 2021
Merged

fix(ext/fetch): avoid panic when header is invalid #12244

merged 3 commits into from
Sep 29, 2021

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Sep 27, 2021

fix #12236

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

lucacasonato
lucacasonato reviewed Sep 27, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this?

lucacasonato
lucacasonato reviewed Sep 28, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic. Great test :-)

While you are at it, can you also remove the .unwrap from HeaderName::from_bytes, and add a test for that? Alternatively we can do that in a follow-up PR, and I'll merge this one. Let me know what works better for you!

@ahabhgk
Copy link
Contributor Author

ahabhgk commented Sep 29, 2021 •
edited
Loading

This looks fantastic. Great test :-)

While you are at it, can you also remove the .unwrap from HeaderName::from_bytes, and add a test for that? Alternatively we can do that in a follow-up PR, and I'll merge this one. Let me know what works better for you!

Of course I can, let me remove the .unwrap from HeaderName::from_bytes and add a test for it.

lucacasonato
lucacasonato approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ahabhgk!

cli/tests/unit/fetch_test.ts Show resolved Hide resolved
@ahabhgk
Copy link
Contributor Author

ahabhgk commented Sep 29, 2021

I updated the wpt result, now the workflow should pass.

@lucacasonato lucacasonato merged commit 923d9c7 into denoland:main Sep 29, 2021
@ahabhgk ahabhgk deleted the fix-fetch-panic branch September 29, 2021 16:44
ry pushed a commit that referenced this pull request Oct 4, 2021
@ahabhgk @ry
fix(ext/fetch): avoid panic when header is invalid (#12244)
55cbd98
crowlKats added a commit to crowlKats/deno that referenced this pull request Jan 5, 2022
@crowlKats
add forbidden headers test & use patch from denoland#12244
d44dd9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in ext/fetch during WPT
3 participants
@ahabhgk @CLAassistant @lucacasonato