Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Show the URL of streaming WASM modules in stack traces #12268

Merged
merged 2 commits into from
Oct 10, 2021
Merged

feat: Show the URL of streaming WASM modules in stack traces #12268

merged 2 commits into from
Oct 10, 2021

Commits on Oct 7, 2021

  1. feat: Show the URL of streaming WASM modules in stack traces 

    WebAssembly modules compiled through `WebAssembly.compile()` and similar
non-streaming APIs don't have a URL associated to them, because they
have been compiled from a buffer source. In stack traces, V8 will use
a URL such as `wasm://wasm/d1c677ea`, with a hash of the module.

However, wasm modules compiled through streaming APIs, like
`WebAssembly.compileStreaming()`, do have a known URL, which can be
obtained from the `Response` object passed into the streaming APIs. And
as per the developer-facing display conventions in the WebAssembly
Web API spec, this URL should be used in stack traces. This change
implements that.

Closes denoland#12151.
    Andreu Botella committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    4fc837f View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2021

  1. The test needs http_server: true

    Andreu Botella committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    ec1747a View commit details
    Browse the repository at this point in the history