Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/ffi): formatting dlopen errors on Windows #12301

Merged
merged 18 commits into from
Oct 6, 2021
Merged

fix(ext/ffi): formatting dlopen errors on Windows #12301

merged 18 commits into from
Oct 6, 2021

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Oct 2, 2021 •
edited
Loading

Fixes #11632

@littledivy littledivy changed the title fix(ext/ffi): Windows dlopen IoError formatting fix(ext/ffi): formatting dlopen errors on Windows Oct 2, 2021
@littledivy littledivy marked this pull request as ready for review October 2, 2021 17:03
AaronO
AaronO previously requested changes Oct 2, 2021
View reviewed changes
Copy link
Contributor

@AaronO AaronO left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered moving out the error mapping to its own function ? I think that would be cleaner

@littledivy littledivy requested a review from AaronO October 3, 2021 09:56
dsherret
dsherret requested changes Oct 3, 2021
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. It would be useful to add some windows only unit tests doing something like format_error(io:Error::from_raw_os_error(code), path).

ext/ffi/lib.rs Outdated Show resolved Hide resolved
ext/ffi/lib.rs Outdated Show resolved Hide resolved
ext/ffi/lib.rs Outdated Show resolved Hide resolved
ext/ffi/lib.rs Show resolved Hide resolved
dsherret
dsherret approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this. There are just some merge conflicts that need to be resolved though.

@piscisaureus piscisaureus dismissed AaronO’s stale review October 5, 2021 15:37

Comments have been addressed.

@bartlomieju bartlomieju merged commit 2b39e74 into denoland:main Oct 6, 2021
@littledivy littledivy deleted the fix/ffi-dlopen-error branch October 6, 2021 02:37
@littledivy littledivy mentioned this pull request Oct 6, 2021
Merged
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Oct 10, 2021
@littledivy @bartlomieju
fix(ext/ffi): formatting dlopen errors on Windows (denoland#12301)
6402366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

@dsherret dsherret dsherret approved these changes

@AaronO AaronO Awaiting requested review from AaronO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrectly using 32 bit dll in Deno.dlopen on Windows leads to error message with format string
5 participants
@littledivy @piscisaureus @AaronO @dsherret @bartlomieju