Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): Getting navigator.hardwareConcurrency on workers shouldn't throw #12354

Merged
merged 1 commit into from
Oct 7, 2021
Merged

fix(runtime): Getting navigator.hardwareConcurrency on workers shouldn't throw #12354

merged 1 commit into from
Oct 7, 2021

Conversation

andreubotella
Copy link
Contributor

Closes #12353.

lucacasonato
lucacasonato approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :-)

@lucacasonato lucacasonato merged commit e8b3ffd into denoland:main Oct 7, 2021
@andreubotella andreubotella deleted the worker-hardware-concurrency branch October 7, 2021 17:39
bartlomieju pushed a commit to bartlomieju/deno that referenced this pull request Oct 10, 2021
@bartlomieju
fix(runtime): Getting navigator.hardwareConcurrency on workers shou…
6b02375 
…ldn't throw (denoland#12354)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting navigator.hardwareConcurrency throws on workers
2 participants
@andreubotella @lucacasonato