refactor(cli/fmt_errors): Format stack frames in prepareStackTrace() #4706
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4690 (comment), cc @ry @piscisaureus.
This implements the coloring in
prepareStackTrace()
and passes the formatted strings to Rust viaerror.__formattedFrames
.Since the formatting in
prepareStackTrace()
is properly aligned with V8, this fixes 1/3 and 2/3 of #4705. 3/3 (which involves a built-in function frame) requires making line and column numbers optional in Rust and then just removing the null guard, I'll see about that later.The source line formatting is still duplicated in
core/js_error.rs
andcli/fmt_errors.rs
.