Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed: [std/multipart] make readForm() return value more type safe #4710

Merged
merged 2 commits into from
Apr 12, 2020
Merged

changed: [std/multipart] make readForm() return value more type safe #4710

merged 2 commits into from
Apr 12, 2020

Conversation

keroxp
Copy link
Contributor

@keroxp keroxp commented Apr 11, 2020

  • Currently return value of MultipartReader.readForm() is {[key: string}: string|FormFile|null}
  • This definition is ambiguous for receiver.
  • Return value is now similar to Go's Form( https://golang.org/pkg/mime/multipart/#Form )

ry
ry approved these changes Apr 12, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 6e0c9a0 into denoland:master Apr 12, 2020
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@keroxp
refactor(std/multipart): make readForm() return value more type safe (d…
1f04527 
…enoland/deno#4710)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@keroxp
refactor(multipart): make readForm() return value more type safe (den…
d9c3e80 
…oland/deno#4710)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@keroxp @caspervonb
refactor(multipart): make readForm() return value more type safe (den…
49b7a0d 
…oland/deno#4710)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@keroxp @caspervonb
refactor(multipart): make readForm() return value more type safe (den…
d41da3f 
…oland/deno#4710)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@keroxp @caspervonb
refactor(multipart): make readForm() return value more type safe (den…
179e123 
…oland/deno#4710)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@keroxp @caspervonb
refactor(multipart): make readForm() return value more type safe (den…
70224d5 
…oland/deno#4710)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@keroxp @caspervonb
refactor(multipart): make readForm() return value more type safe (den…
05b7303 
…oland/deno#4710)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@keroxp @denobot
refactor(multipart): make readForm() return value more type safe (den…
3d60a9b 
…oland/deno#4710)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@keroxp @denobot
refactor(multipart): make readForm() return value more type safe (den…
5b228a7 
…oland/deno#4710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keroxp @ry