Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove std/testing/format.ts #4749

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Remove std/testing/format.ts #4749

merged 1 commit into from
Apr 15, 2020

Conversation

nayeemrmn
Copy link
Collaborator

Closes #4023.

@ry
Copy link
Member

ry commented Apr 14, 2020

Is there a flaky test?

@nayeemrmn
Copy link
Collaborator Author

nayeemrmn commented Apr 14, 2020 •
edited
Loading

Seems to be #4725. I wanted to get one green first to confirm but I guess so. cc @bartlomieju

@nayeemrmn nayeemrmn changed the title Remove std/testing/format.ts WIP: Remove std/testing/format.ts Apr 15, 2020
@nayeemrmn nayeemrmn changed the title WIP: Remove std/testing/format.ts Remove std/testing/format.ts Apr 15, 2020
ry
ry approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ry ry merged commit 926db01 into denoland:master Apr 15, 2020
@nayeemrmn nayeemrmn deleted the remove-std-testing-format branch April 15, 2020 14:25
@RobDWaller RobDWaller mentioned this pull request May 18, 2020
Closed
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@nayeemrmn
Remove std/testing/format.ts (denoland/deno#4749)
f050175
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn
Remove testing/format.ts (denoland/deno#4749)
7986882
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn @caspervonb
Remove testing/format.ts (denoland/deno#4749)
3b5f38a
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@nayeemrmn @caspervonb
Remove testing/format.ts (denoland/deno#4749)
7cc1d05
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
Remove testing/format.ts (denoland/deno#4749)
3d76ea8
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
Remove testing/format.ts (denoland/deno#4749)
891bbb5
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @caspervonb
Remove testing/format.ts (denoland/deno#4749)
5a57953
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@nayeemrmn @denobot
Remove testing/format.ts (denoland/deno#4749)
3eddd6a
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@nayeemrmn @denobot
Remove testing/format.ts (denoland/deno#4749)
1fcef0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std: is testing/format.ts needed?
2 participants
@nayeemrmn @ry