feat(cli): Deno.emit supports bundling as IIFE #9291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Jan 27, 2021
cli/tests/compiler_api_test.ts
Outdated
| assert(diagnostics); | ||
| assertEquals(diagnostics.length, 0); | ||
| assertEquals(Object.keys(files).length, 1); | ||
| assert(files["deno:///bundle.js"].startsWith("function() {\n")); |
There was a problem hiding this comment.
Should it start with (function() {\n?
There was a problem hiding this comment.
I think I made a mistake.
I'll fix it and publish a new version. (fixer should be called after wrapping with iife, but it's not)
There was a problem hiding this comment.
I published a new version of swc_bundler.
|
Since this is a new feature (albeit for an unstable option) I don't think we should land this until 1.8. It should be relatively easy to rebase, so we can update the bundler from swc for it. |
kitsonk
force-pushed
the
kitsonk/issue9204
branch
from
cf5cfe5
to
c55cd07
Compare
kitsonk
force-pushed
the
kitsonk/issue9204
branch
from
c55cd07
to
2be3047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9204
Thanks @kdy1 for adding it to swc! Finally got around to adding it to Deno.