Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Throw DataCloneError if SAB cannot be cloned (#781)" #782

Closed
wants to merge 1 commit into from
Closed

Revert "Throw DataCloneError if SAB cannot be cloned (#781)" #782

wants to merge 1 commit into from

Conversation

ry
Copy link
Member

@ry ry commented Sep 18, 2021

This seems to have caused the CI to go red with a segfault on Windows? https:/denoland/rusty_v8/runs/3640447313

This reverts commit 09347d3.

@bnoordhuis
Copy link
Contributor

bnoordhuis commented Sep 18, 2021 •
edited
Loading

That segfault is #714. It's been happening sporadically for months.

edit: another main run: https:/denoland/rusty_v8/actions/runs/1248635300 - okay

@andreubotella andreubotella mentioned this pull request Sep 19, 2021
Merged
@ry
Copy link
Member Author

ry commented Sep 20, 2021

unrelated - as ben said

@ry ry closed this Sep 20, 2021
@ry ry deleted the revert-sab branch September 20, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ry @bnoordhuis