-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving local/nested node_modules folder #161
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are cases that arise when a node module specifies it's own node_modules folder (for instance when wanting to tie itself to a particular version of a package). Example below:
In the case above, requiring
should return the dependencies
which is does not.
Another issue is that if the base node_modules has a version of child_packageA, it will refer to that as a dependency, which is wrong (and can have adverse effects if it is a different version of the package). For instance
Returns
The main issue is related to the
directory
used when passing a file toprecient
to get the dependencies. When the file is part of node module/package, the directory should be the root of that package (as all files are contained in there)Pull request #162 is a potential fix for this.
The text was updated successfully, but these errors were encountered: