fix: add Lazy-load Axe::API::Run to improve boot time
#396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It saves 95% of load time when doing `require "axe-rspec"`. The time is actually spent loading the `virtus` library. Deferring the loading of `Axe::API::Run` until needed does in turn defer the loading of `virtus` library.
michael-siek
previously approved these changes
Jul 23, 2024
stephenmathieson
previously requested changes
Jul 23, 2024
There was a problem hiding this comment.
We should give @cbliard credit as they originally wrote this fix.
git commit --author="Christophe Bliard <[email protected]>"
See https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---authorltauthorgt
michael-siek
approved these changes
Aug 13, 2024
scottmries
dismissed
stephenmathieson’s stale review
Requested changes are in place with approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It saves 95% of load time when doing
require "axe-rspec".The time is actually spent loading the
virtuslibrary. Deferring the loading ofAxe::API::Rununtil needed does in turn defer the loading ofvirtuslibrary.No QA required.