Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(capybara): open selected browser #305

Merged
merged 2 commits into from
Apr 24, 2023
Merged

fix(capybara): open selected browser #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae2c02b
fix(capybara): open selected browser
AdnoC Apr 24, 2023
15bbd46
test
AdnoC Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/axe-core-capybara/lib/axe-capybara.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ def self.configure(browser = :firefox)
private

def self.get_driver(browserSymbol)
Capybara::Selenium::Driver.new nil, :browser => browserSymbol
Capybara::Selenium::Driver.new(nil, browser: browserSymbol)
end
end
13 changes: 13 additions & 0 deletions packages/axe-core-capybara/spec/axe-capybara_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,19 @@
expect(is_chrome).to be true
end

it "defaults to firefox" do
driver = AxeCapybara.configure() do
end
browser = driver.page.options[:browser]
expect(browser).to be :firefox
end
it "sets browser correctly" do
driver = AxeCapybara.configure(:chrome) do
end
browser = driver.page.options[:browser]
expect(browser).to be :chrome
end

it "should yield configuration with specified jslib path" do
different_axe_path = "different-axe-path/axe.js"

Expand Down