Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page type incompatibility when updating @playwright/test #1087

Open
1 task done
ritchieanesco opened this issue Jul 29, 2024 · 3 comments
Open
1 task done

Page type incompatibility when updating @playwright/test #1087

ritchieanesco opened this issue Jul 29, 2024 · 3 comments
Labels
PACKAGE: playwright question Further information is requested

Comments

@ritchieanesco
Copy link

Product

playwright

Product Version

4.9.1

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

Expectation

No type errors when updating @playwright/tests package

Actual

Page type error occurs when running tsc --noEmit after updating @playwright/tests package

How to Reproduce

  1. Use Page type from @playwright.tests package in your tests.
  2. Use a version of @axe-core/playwright that uses a older version of @playwright/tests.
  3. Run tsc --noEmit
@Zidious
Copy link
Contributor

Zidious commented Jul 29, 2024

Hey @ritchieanesco,

What version were you on and what version of @playwright/test caused the type break?

Thanks!

@Zidious Zidious added question Further information is requested PACKAGE: playwright labels Jul 29, 2024
@DyHex
Copy link

DyHex commented Aug 14, 2024

@Zidious

Type 'import("C:/Users/....../Playwright/node_modules/.pnpm/[email protected]/node_modules/playwright-core/types/types").Page' is not assignable to type 'import("C:/Users/....../Playwright/node_modules/.pnpm/[email protected]/node_modules/playwright-core/types/types").Page'.ts(2322)
index.d.ts(5, 5): The expected type comes from property 'page' which is declared here on type 'AxePlaywrightParams'

Generally get this error everytime I upgrade playwright/test to a new version

4lejandrito added a commit to jaimelr10/liferay-portal that referenced this issue Sep 27, 2024
4lejandrito added a commit to jaimelr10/liferay-portal that referenced this issue Sep 30, 2024
@florestankorp
Copy link

Same here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PACKAGE: playwright question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants