test: fix tests for handling lazy iframe #1052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Superseded by #1053 |
This was referenced May 9, 2024
straker
added a commit
that referenced
this pull request
May 9, 2024
Fixes the broken lazy load iframe tests. Ref: #1052 No QA needed.
straker
added a commit
to dequelabs/axe-core-gems
that referenced
this pull request
May 9, 2024
Fixes the broken lazy load iframe tests. Ref: dequelabs/axe-core-npm#1052 No QA needed.
straker
added a commit
to dequelabs/axe-core-nuget
that referenced
this pull request
May 9, 2024
Fixes the broken lazy load iframe tests. Ref: dequelabs/axe-core-npm#1052 No QA needed.
straker
added a commit
to dequelabs/axe-core-maven-html
that referenced
this pull request
May 9, 2024
Fixes the broken lazy load iframe tests. Ref: dequelabs/axe-core-npm#1052 No QA needed. --------- Co-authored-by: michael-siek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome v124 now has the capability to load lazy loaded iframes. To support both older versions of chrome (e.g. installing older versions of playwright or puppeteer) we'll branch the test to look at the
frame-testedrule in different places. Older versions will look inincomplete, newer versions will look inpasses. Note that since the iframe is lazy loaded the page load event is fired before the frame is loaded, so I needed to add a delay after the page loaded to ensure the iframes were all settled (otherwise the tests were flakey).At a later date we'll create a CI job that installs an older version of the chrome for each of the packages to ensure we don't have a regression going forward.
QA notes: test puppeteer version < 22 with lazy loaded iframe to see
frame-testedas incomplete, test with latest version to seeframe-testedas passes. For webdevierio and webdriverjs you'll need to set the chrome binary and/or chromedriver to a version < 124 to seeframe-testedin incomplete, and the latest version to seeframe-testedas passes.