Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Prepare for the switch to NPM workspaces #757

Closed
wants to merge 4 commits into from
Closed

refactor: Prepare for the switch to NPM workspaces #757

wants to merge 4 commits into from

Conversation

not-my-profile
Copy link
Contributor

No description provided.

@not-my-profile
refactor(reporter-earl): import jest types directly
93b0eb6 
We want to switch from `lerna bootstrap` to NPM workspaces,
doing so however results in a TypeScript error since we had
both @types/mocha and @types/jest ... which conflict.

This commit works around this conflict by
importing the jest types directly.
@not-my-profile
refactor(cli): use require.resolve
dc8b88f
@not-my-profile
refactor(reporter-earl): stop hard-coding node_modules/ in package.json
2b9574d
@not-my-profile
fix reporter-earl
b99111f
@not-my-profile not-my-profile requested a review from a team as a code owner June 30, 2023 19:02
@not-my-profile not-my-profile mentioned this pull request Jun 30, 2023
Merged
@not-my-profile
Copy link
Contributor Author

(I am afraid I again don't have time to debug the CI failure.)

@not-my-profile not-my-profile marked this pull request as draft August 8, 2023 04:04
@straker
Copy link
Contributor

straker commented Sep 11, 2023

Done in #687

@straker straker closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@not-my-profile @straker