Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify Github Releases are being tagged correctly #158

Closed
dequejenn opened this issue Feb 12, 2024 · 0 comments · Fixed by #162
Closed

Verify Github Releases are being tagged correctly #158

dequejenn opened this issue Feb 12, 2024 · 0 comments · Fixed by #162
Assignees
@michael-siek
Labels
in sprint Ticket is in current sprint QA: none This ticket does not require QA signoff TYPE: task Ticket is for non-dev work

Comments

@dequejenn
Copy link
Contributor

Our Github releases are getting tagged to the commit right before the release. This means our versions are one behind and changelog entry does not exist for that release. The maven release looks to be correct.

Example: 4.4.2 release changelog and pom file
@dequejenn dequejenn added in sprint Ticket is in current sprint TYPE: task Ticket is for non-dev work QA: none This ticket does not require QA signoff labels Feb 12, 2024
@michael-siek michael-siek mentioned this issue Feb 14, 2024
Merged
michael-siek added a commit that referenced this issue Feb 14, 2024
@michael-siek
ci: add release target branch when releasing (#162)
756a4be 
Closes: #158

no qa required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-siek michael-siek

Labels
in sprint Ticket is in current sprint QA: none This ticket does not require QA signoff TYPE: task Ticket is for non-dev work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add release target branch when releasing dequelabs/axe-core-nuget
2 participants
@michael-siek @dequejenn