New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link-in-text-block should consider parent nodes & descending images #4126

Open

WilcoFiers opened this issue Aug 11, 2023 · 1 comment

Assignees

Labels

fix rules support

Milestone

Contributor

WilcoFiers commented Aug 11, 2023

The following should pass the link-in-text-block rule:

<p>
  Lorem ipsum 
  <u><a href="#">dolor</a></u> 
  sit amet consectetur adipisicing elit. Ea officiis
  <a href="#"><img width="16" height="16"> exercitationem</a> 
  ullam inventore facere quaerat, itaque eaque. Eaque 
  <a href="#"><svg width="16" height="16"></svg>consectetur</a>,
  doloremque nostrum, vel animi quis pariatur, qui omnis inventore cum harum!
</p>

The text was updated successfully, but these errors were encountered:

WilcoFiers added fix rules support labels

WilcoFiers added this to the Axe-core 4.9 milestone

Contributor

straker commented Aug 23, 2023 •

edited

Loading

This should pass for the 2 cases:

link being wrapped by a u element
link with graphical content (img, svg, canvas, object, etc.)

straker mentioned this issue

fix(link-in-text-block): take into account ancestor inline element styles #4135

Draft

WilcoFiers assigned straker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment