Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-hidden-focus fix does not suggest unhiding the parent element #4552

Open
1 task done
andrewhick opened this issue Aug 5, 2024 · 1 comment
Open
1 task done
Labels
rule metadata Issues in the rule metadata code (lib/rules)
Milestone

Comments

@andrewhick
Copy link

Product

axe Extension

Product Version

4.9.1

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

Expectation

The Axe issue "ARIA hidden element must not be focusable or contain focusable elements" should account for the possibility that the ARIA hidden element could have been hidden incorrectly.

In some cases, we encounter content which is visually present but incorrectly hidden using ARIA - meaning that some users will perceive different content.

We would suggest amending the potential fix to:

To solve this problem, you need to fix one of the following:

  • Focusable content should be disabled or removed from the DOM
  • [ADD:] The hidden element should be made visible to assistive technologies

Actual

The fix only suggests the option of removing focusable content: "To solve this problem, you need to fix the following: Focusable content should be disabled or be removed from the DOM."

How to Reproduce

Go to "Hidden element containing focusable elements" on this test page and run Axe DevTools. This example reflects one which was recently found in a real-life scenario.

@andrewhick andrewhick added the ungroomed Ticket needs a maintainer to prioritize and label label Aug 5, 2024
@github-actions github-actions bot added the extension Axe Firefox or Chrome extension issues label Aug 5, 2024
@straker straker added this to the Axe-core 4.11 milestone Aug 8, 2024
@straker straker added rule metadata Issues in the rule metadata code (lib/rules) and removed extension Axe Firefox or Chrome extension issues ungroomed Ticket needs a maintainer to prioritize and label labels Aug 8, 2024
@straker
Copy link
Contributor

straker commented Aug 8, 2024

Thanks for the suggestion. We'll add this to the 4.11 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule metadata Issues in the rule metadata code (lib/rules)
Projects
None yet
Development

No branches or pull requests

2 participants