fix(button-name,input-button-name,input-img-alt): allow label to give accessible name #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Oct 11, 2024
Co-authored-by: Wilco Fiers <[email protected]>
dbjorge
previously requested changes
Oct 14, 2024
WilcoFiers
approved these changes
Oct 15, 2024
straker
added a commit
that referenced
this pull request
Oct 16, 2024
… accessible name (#4607) I'm not sure if this should close #4472 as that also deals with buttons with a different role running `button-name`. For sure this closes #3696 Closes: #3696 --------- Co-authored-by: Wilco Fiers <[email protected]>
This was referenced Oct 16, 2024
WilcoFiers
added a commit
that referenced
this pull request
Oct 16, 2024
### [4.10.1](v4.10.0...v4.10.1) (2024-10-16) ### Bug Fixes - **aria-allowed-role:** add form to allowed roles of form element ([#4588](#4588)) ([d462d67](d462d67)), closes [/github.com/dequelabs/axe-core/blob/develop/lib/standards/html-elms.js#L264](https:/dequelabs/dequelabs/axe-core/blob/develop/lib/standards/html-elms.js/issues/L264) - **axe.d.ts:** add typings for preload options object ([#4543](#4543)) ([72e269f](72e269f)) - **button-name,input-button-name,input-img-alt:** allow label to give accessible name ([#4607](#4607)) ([364eb72](364eb72)), closes [#4472](#4472) [#3696](#3696) [#3696](#3696) - **get-ancestry:** add nth-child selector for multiple siblings of shadow root ([#4606](#4606)) ([bdd94a2](bdd94a2)), closes [#4563](#4563) - **rules:** Change "alternate text" to "alternative text" ([#4582](#4582)) ([31e0f61](31e0f61))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided that the issue with Dragon NaturallySpeaking was a minor one and that there are ways to work around the issue (such as grid selection), and that there are different voice controlled assistive technologies that can also be used, so it shouldn't block allowing giving an accessible name to buttons.
I'm not sure if this should close #4472 as that also deals with buttons with a different role running
button-name. For sure this closes #3696.Closes: #3696