fix: honor defaults from drain dialog in request #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgalind1
changed the title
|
@derailed would you mind helping approving the workflow again pls? |
Merged
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
* fix: honor defaults from dialog into request * reuse options/defaults from arg * fix additional references for defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
Draining a node doesn't honor default values shown in the dialog. In particular drain happens with grace period of 0s instead of the default of -1
How to Reproduce
When draining a node, we noticed that when you do not modify the default gracePeriod of -1 from the UI, based on the API logs it is sending
gracePeriod: 0, which it's pretty similar to a force non-graceful termination which doesn't let the termination flow go.If we update the default to a different value, that other value is the one that is sent as expected
If you delete the default gracePeriod of -1 from the dialog, and type again -1, this time it works and do not sends a gracePeriod, so I wonder if our issue is related to this same issue
Expected behavior
Drain operation should honor default values shown in the dialog
Possible related to issue #2129