Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added method overloads to ISetupSequentialResult async void methods #1006

Merged
merged 1 commit into from
Apr 25, 2020

Conversation

fuzzybair
Copy link
Contributor

Added method overloads to ISetupSequentialResult PassAsync and ThrowsAsync for async methods with void return

Copy link
Contributor

@stakx stakx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Two suggestions in the review comments below, I won't merge this straight away in case you want to do something about them.

tests/Moq.Tests/SequenceExtensionsFixture.cs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@fuzzybair
Copy link
Contributor Author

Applied code review suggestions.

@stakx stakx merged commit 6069ad2 into devlooped:master Apr 25, 2020
@stakx
Copy link
Contributor

stakx commented Apr 25, 2020

All good. Thank you for contributing!

@stakx stakx modified the milestones: 4.15.0, 4.14.1 Apr 27, 2020
@devlooped devlooped locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants