Add test from #343 to regression test suite #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which demonstrates that Moq no longer cares about the precise return type of methods if they otherwise match. This enables some scenarios involving generic methods that previously weren't supported. (It seems correct that Moq no longer tries to match method's return types exactly. While technically not incorrect, it is unusual behavior for most people coming from VB.NET or C#, where the return type is not considered part of the method signature WRT method resolution.)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which demonstrates that Moq no longer cares (because of #904) about the precise return type of methods if they otherwise match. This enables some scenarios involving generic methods that previously weren't supported.
(It seems correct that Moq no longer tries to match method's return types exactly. While technically not incorrect, it is unusual behavior for most people coming from VB.NET or C#, where the return type is not
considered part of the method signature WRT method resolution.)
Closes #906.
/cc @oddbear who originally came up with that test