Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let InnerMockSetup (i.e. internal setups for cached return values) match generic args exactly instead of by assignment compatibility. #949

Merged
merged 4 commits into from
Oct 19, 2019
Merged

Let InnerMockSetup (i.e. internal setups for cached return values) match generic args exactly instead of by assignment compatibility. #949

merged 4 commits into from
Oct 19, 2019

Commits on Oct 19, 2019

  1. Regression re: cached auto-mocked return values

    @stakx
    stakx committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    13499cb View commit details
    Browse the repository at this point in the history

  2. Generic args must match exactly for inner mock setups 

    While this fixes the regression documented in the previous commit, it
might be an insufficent solution in general. Perhaps it would be more
correct to take co-/contra-variance into account and select a compari-
son mode per generic argument depending on whether it appears in a
input and/or output position?
    @stakx
    stakx committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    f40de72 View commit details
    Browse the repository at this point in the history

  3. Reduce code duplication in types.CompareTo

    @stakx
    stakx committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    429d44b View commit details
    Browse the repository at this point in the history

  4. Update the changelog

    @stakx
    stakx committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    dfbd9cc View commit details
    Browse the repository at this point in the history