Ensure SetupAllProperties stubs all accessors of partially overridden properties
#950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakx
force-pushed
the
split-properties
branch
2 times, most recently
from
19c5fae
to
64774b9
Compare
stakx
force-pushed
the
split-properties
branch
from
64774b9
to
cbeb661
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #886.
The newly introduced helper extension methods
property.CanRead(out MethodInfo getter)andproperty.CanWrite(out MethodInfo setter)may also be applicable elsewhere in the code base where we currently useproperty.CanReadandproperty.CanWrite. Care should be taken when replacing the latter with the former as this might change the code's semantics.