Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI app #4

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

GUI app #4

wants to merge 46 commits into from

Conversation

joemphilips
Copy link
Contributor

I've created an GUI application with Avalonia.FUNCUI for the sake of my learning.
Since it seems working fine for the basic operation,I will leave the result here. But I think this should not get merged for the following reason.

  1. The UI is far from ideal
  2. It is written in F#, and I know it is not as popular as C#.
  3. We must refactor it anyway when the messaging protocol gets settled.
  4. It is useless for non tech-savvy user unless we integrate the wallet feature into it. But if I will do so, I'd rather create a new independent repository. Because I want to add some deps.

(You may wonder why I had to make this PR then. Well... I just wanted to put it into someplace public, someone else might get interested to it.)

Some screenshots

スクリーンショット 2020-10-12 12 28 33

スクリーンショット 2020-10-12 12 29 09

スクリーンショット 2020-10-12 12 40 00

@junderw
Copy link

junderw commented Oct 12, 2020

Very cool.

@NicolasDorier
Copy link
Member

NicolasDorier commented Oct 12, 2020

awesome, will merge soon. I have lot's of code to merge to catch up with the new version of the spec, no change to the external interface so there won't be any issue! :)
What is "event local name". An event full name is "oracleName/localName". But here there is another "local name"?

@joemphilips
Copy link
Contributor Author

joemphilips commented Oct 12, 2020

awesome, will merge soon

Ultimately it is up to you, but I don't recommend you to do it right now. This PR is good enough for reviewing and dogfooding, but before it gets merged I have to

  1. Add tests
  2. add CLI options to run in a different network and datadir.

Also some of the view might get pointless in the future (e.g. Checksig should not be done manually)
So again, this is just an experiment. I would like to have a feedback but there is no need for hurry.

What is "event local name". An event full name is "oracleName/localName". But here there is another "local name"?

Would you point me the code it says so? Or the GUI view?

@NicolasDorier
Copy link
Member

@joemphilips sorry I misunderstood, that was the list of dlcs.

@NicolasDorier
Copy link
Member

You can remove the DLCList, I integrated it. (Though it only list names)

Now I also support finally the official dlcspec! The CLI did not changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants