Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMAS support #21

Merged
merged 11 commits into from
Sep 28, 2024
Merged

IMAS support #21

merged 11 commits into from
Sep 28, 2024

Conversation

dgarnier
Copy link
Owner

Also fix errors with mypy and coverage. (Issue #16)

@dgarnier dgarnier linked an issue Sep 23, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 95.17241% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.32%. Comparing base (dac4566) to head (41ad1e6).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
python/dipoleq/imas.py 97.07% 5 Missing ⚠️
python/dipoleq/post_process.py 88.09% 5 Missing ⚠️
python/dipoleq/util.py 90.90% 3 Missing ⚠️
python/dipoleq/imas_dipole_extras.py 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   75.75%   82.32%   +6.57%     
==========================================
  Files          11       14       +3     
  Lines        1031     1341     +310     
==========================================
+ Hits          781     1104     +323     
+ Misses        250      237      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dgarnier dgarnier marked this pull request as ready for review September 28, 2024 16:36
@dgarnier dgarnier self-assigned this Sep 28, 2024
@dgarnier dgarnier merged commit 7b36e4e into main Sep 28, 2024
23 checks passed
@dgarnier
Copy link
Owner Author

I'm happy with this as an initial attempt. Not all derived quantities are in the IMAS yet, but the API looks good. Might mean a bump in subversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IMAS / OMAS
1 participant