Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (hopefully) GUI test crashes for #1018 #1

Open
wants to merge 1 commit into
base: testing_ouu_discrete_uncertain_parameters
Choose a base branch
from
Open

Fix (hopefully) GUI test crashes for #1018 #1

wants to merge 1 commit into from

Conversation

lbianchi-lbl
Copy link

Motivation

Changes proposed in this PR:

  • Add improved patching for handling modal dialogs that bypasses exec_() instead of requiring extra threads
  • Improve cleanup for main_window and qtbot fixtures to avoid dangling references

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl
Try using another handler for modal dialog
a5bf0bd 
Try alternative strategy to handle modal dialogs


Run Black


Try with alternative strategy to handle main window close event


Run Black


Try if using --pyargs makes a difference


Try adding explicit cleanup for qtbot instance
@lbianchi-lbl
Copy link
Author

@dghoshal-lbl I've been testing this in the CI on my fork and it seems to be working (see https:/lbianchi-lbl/FOQUS/actions/runs/2105771584). Feel free to merge it in your testing_ouu_discrete_uncertain_parameters branch, which will trigger the CI in CCSI-Toolset#1018.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lbianchi-lbl